-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add double marry malfeasance proof #6219
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6219 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 308 309 +1
Lines 33913 34033 +120
=========================================
+ Hits 27829 27922 +93
- Misses 4311 4326 +15
- Partials 1773 1785 +12 ☔ View full report in Codecov by Sentry. |
var vrfNonce types.Hash32 | ||
binary.LittleEndian.PutUint64(vrfNonce[:], atx.VRFNonce) | ||
tree.AddLeaf(vrfNonce.Bytes()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain why is it important that leaves are all 32B?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly the validate Merkle proof function assumes that all values are 32 bytes and appends them with zeroes if they are not.
So if we don't create the Merkle proof with 32 byte values the proof will fail to validate 😕
bors merge |
## Motivation Closes #6218
Pull request successfully merged into develop. Build succeeded: |
Motivation
Closes #6218
Description
Adds the proof for double marry malfeasance and updates the ATX handler to create and publish one when detected
Test Plan
TODO