[Merged by Bors] - api: v2alpha1: Add labels_per_unit to NetworkService.Info endpoint #6213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacpersaw
requested review from
dshulyak,
fasmat,
poszu,
ivan4th and
acud
as code owners
poszu
reviewed
Aug 5, 2024
node/node.go
Outdated
| @@ -1559,7 +1559,8 @@ func (app *App) grpcService(svc grpcserver.Service, lg log.Log) (grpcserver.Serv | |||
| service := v2alpha1.NewNetworkService( | |||
| app.clock.GenesisTime(), | |||
| app.Config.Genesis.GenesisID(), | |||
| app.Config.LayerDuration) | |||
| app.Config.LayerDuration, | |||
| app.postSupervisor.Config().LabelsPerUnit) | |||
There was a problem hiding this comment.
How about
Suggested change
| app.postSupervisor.Config().LabelsPerUnit) | |
| app.Config.POST.LabelsPerUnit) |
fasmat
reviewed
Aug 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6213 +/- ##
=======================================
Coverage 81.9% 82.0%
=======================================
Files 308 308
Lines 33843 33844 +1
=======================================
+ Hits 27742 27755 +13
+ Misses 4325 4315 -10
+ Partials 1776 1774 -2 ☔ View full report in Codecov by Sentry. |
fasmat
approved these changes
Aug 5, 2024
|
bors merge |
|
Canceled. |
|
bors merge |
|
Build failed: |
|
bors merge |
|
Build failed:
|
|
bors merge |
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
kacpersaw
added a commit
that referenced
this pull request
Aug 6, 2024
kacpersaw
added a commit
that referenced
this pull request
Aug 6, 2024
[backport] api: v2alpha1: Add labels_per_unit to NetworkService.Info endpoint (#6213)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spacemeshos/api#365