Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - sql: improve database schema handling #6003

Closed
wants to merge 60 commits into from

sql: ignore whitespace during schema drift checks

2e7e150
Select commit
Loading
Failed to load commit list.
Closed

[Merged by Bors] - sql: improve database schema handling #6003

sql: ignore whitespace during schema drift checks
2e7e150
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 20, 2024 in 1s

82.0% (-0.1%) compared to 48b77e7

View this Pull Request on Codecov

82.0% (-0.1%) compared to 48b77e7

Details

Codecov Report

Attention: Patch coverage is 76.11940% with 112 lines in your changes missing coverage. Please review.

Project coverage is 82.0%. Comparing base (48b77e7) to head (2e7e150).
Report is 1 commits behind head on develop.

Files Patch % Lines
sql/schema.go 72.0% 19 Missing and 12 partials ⚠️
sql/schemagen/main.go 0.0% 24 Missing ⚠️
sql/database.go 87.1% 11 Missing and 4 partials ⚠️
sql/localsql/localsql.go 68.5% 8 Missing and 3 partials ⚠️
sql/statesql/statesql.go 72.7% 5 Missing and 4 partials ⚠️
sql/migrations.go 66.6% 5 Missing and 3 partials ⚠️
checkpoint/recovery.go 76.4% 2 Missing and 2 partials ⚠️
node/node.go 63.6% 3 Missing and 1 partial ⚠️
sql/malsync/malsync.go 66.6% 4 Missing ⚠️
syncer/malsync/syncer.go 88.8% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff            @@
##           develop   #6003     +/-   ##
=========================================
- Coverage     82.0%   82.0%   -0.1%     
=========================================
  Files          307     312      +5     
  Lines        34106   34327    +221     
=========================================
+ Hits         27996   28153    +157     
- Misses        4332    4389     +57     
- Partials      1778    1785      +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov