Skip to content

Fix fallbacks not being used in the launcher - #251

Merged
PJB3005 merged 1 commit into
space-wizards:masterfrom
VasilisThePikachu:fix-fallback
Nov 20, 2025
Merged

PJB3005 merged 1 commit into
space-wizards:masterfrom
VasilisThePikachu:fix-fallback

Conversation

@VasilisThePikachu

@VasilisThePikachu VasilisThePikachu commented Nov 19, 2025

Copy link
Copy Markdown
Member

Also fixed a random documention comments to use "their" instead of "his"

We may see russian players actually manage to connect to the fallbacks now, also Cloudflare dying won't take us down again.

Also fixed a random documention commentS to use "their" instead of "his"

@PJB3005 PJB3005 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this change is supposed to affect Russian users?

@VasilisThePikachu

VasilisThePikachu commented Nov 20, 2025

Copy link
Copy Markdown
Member Author

I don't understand how this change is supposed to affect Russian users?

I don't believe the fallback system currently actually switches over at all cause every request here was treated as 'sucessfull'. This can also be noticed if you look at the logs of wind. For our playerbase we should be seeing more requests then from our monitoring software.

@PJB3005

PJB3005 commented Nov 20, 2025

Copy link
Copy Markdown

But this change doesn't change that. Russian ISP blockages can't cause requests to fail with weird status codes, it should cause them to fail with network/timeout errors. This code should never be getting ran for those.

@VasilisThePikachu

VasilisThePikachu commented Nov 20, 2025

Copy link
Copy Markdown
Member Author

But this change doesn't change that. Russian ISP blockages can't cause requests to fail with weird status codes, it should cause them to fail with network/timeout errors. This code should never be getting ran for those.

In any case maybe I am wrong maybe I am not. But this still solves the bug that even though http 500 was being reported by cloudflare during the outage. The launcher never even tried to use the fallback and instantly gave up.

I know that's not common but It's still a bug that this solves

@VasilisThePikachu

Copy link
Copy Markdown
Member Author

This will also actually show the status code within the launchers UI instead of saying "an unknown error occurred" if something does happen.

VasilisThePikachu added a commit to VasilisThePikachu/SS14.Launcher that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants