Fix fallbacks not being used in the launcher - #251
Conversation
Also fixed a random documention commentS to use "their" instead of "his"
PJB3005
left a comment
There was a problem hiding this comment.
I don't understand how this change is supposed to affect Russian users?
I don't believe the fallback system currently actually switches over at all cause every request here was treated as 'sucessfull'. This can also be noticed if you look at the logs of wind. For our playerbase we should be seeing more requests then from our monitoring software. |
|
But this change doesn't change that. Russian ISP blockages can't cause requests to fail with weird status codes, it should cause them to fail with network/timeout errors. This code should never be getting ran for those. |
In any case maybe I am wrong maybe I am not. But this still solves the bug that even though http 500 was being reported by cloudflare during the outage. The launcher never even tried to use the fallback and instantly gave up. I know that's not common but It's still a bug that this solves |
|
This will also actually show the status code within the launchers UI instead of saying "an unknown error occurred" if something does happen. |
)" (space-wizards#252) This reverts commit 892d95e.
Also fixed a random documention comments to use "their" instead of "his"
We may see russian players actually manage to connect to the fallbacks now, also Cloudflare dying won't take us down again.