Anchor API sanity - #6990
Open
metalgearsloth wants to merge 1 commit into
Open
Conversation
- Removes the property - Anchoring now works as expected so anchoring twice doesn't silently corrupt. - Kills ReAnchorEvent because any perf gains are not worth the bugs.
Contributor
|
Does this resolve #6739? |
Tayrtahn
reviewed
Aug 14, 2026
Contributor
There was a problem hiding this comment.
I'm excited to see these warnings finally go away!
DrSmugleaf
reviewed
Aug 23, 2026
DrSmugleaf
left a comment
DrSmugleaf
left a comment
Contributor
There was a problem hiding this comment.
I'm on my (half broken) phone so checking would take a while but does this add a VV path for anchored? Or make setting the field directly work
A lot of admins toggle anchored with VV so removing that for them would be very bad
Could just keep the setter around as a private setter maybe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR from the other repo.