Fix RichText height calculation for mixed fonts and inline controls#6393
Open
chavonadelal wants to merge 2 commits intospace-wizards:masterfrom
Open
Fix RichText height calculation for mixed fonts and inline controls#6393chavonadelal wants to merge 2 commits intospace-wizards:masterfrom
chavonadelal wants to merge 2 commits intospace-wizards:masterfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The height of rich text was calculated only based on the current font and increased only when lines were wrapped. Because of this, lines with different font sizes or inline controls could have a reduced height, and the last line could be ignored altogether. Surprisingly, this error occurred periodically rather than constantly.
Fix
The height calculation has been changed to a “per actual line content” model: for each line, the maximum height of elements (font/inline controls) is accumulated. The line height is added once during wrapping and is guaranteed to be taken into account for the last line. This makes Height correct for rendering.
