Turn ColorSelectorSliders into robust xaml + add hex color field to color sliders#6370
Turn ColorSelectorSliders into robust xaml + add hex color field to color sliders#6370portfiend wants to merge 10 commits intospace-wizards:masterfrom
Conversation
|
ready for review |
| /// A LineEdit control that displays in a monospace font. | ||
| /// Because the font is monospace, this allows you to resize the control based on the size | ||
| /// of a given "test string", using <see cref="MeasureText"/>. |
There was a problem hiding this comment.
Uhm, that has nothing to do with it being monospace?
Also this API is too niche to be public.
|
tried my best to address the reviews |
|
|
||
| [GenerateTypedNameReferences] | ||
| [Access(typeof(ColorSelectorSliders))] | ||
| public sealed partial class AlphaSliderChannel : BoxContainer, ISliderChannel |
|
|
||
| [GenerateTypedNameReferences] | ||
| [Access(typeof(ColorSelectorSliders))] | ||
| public sealed partial class ColorSliderChannel : BoxContainer, ISliderChannel |
There was a problem hiding this comment.
just to be clear:
- robust xaml can't generate controls that aren't public, right
- if yes, then in this case, we want these controls to be pure c#?
There was a problem hiding this comment.
robust xaml can't generate controls that aren't public, right
Yes it can?
There was a problem hiding this comment.
oh huh, i feel like i was getting errors last time i tried. i could give it a shot later...? are there examples in the code where this is done?
There was a problem hiding this comment.
are there examples in the code where this is done?
All over the place in engine.
There was a problem hiding this comment.
"robust xaml" as in the generated controls using .xaml files, i mean
There was a problem hiding this comment.
"robust xaml" as in the generated controls using
.xamlfiles, i mean
All over the place in engine.
2 participants
This PR cleans up the initialization code of
ColorSelectorSliders.csby turning it into a Robust XAML control, which, from what I can gather, is something we are aiming to do eventually anyway.It also adds a new hex color field to the control, allowing players to (for once!) actually copy-paste colors to/from the color sliders, which is IMO pretty important for QOL
color.mp4