Add a HTTP client for client/server#6359
Open
DrSmugleaf wants to merge 11 commits intospace-wizards:masterfrom
Open
Add a HTTP client for client/server#6359DrSmugleaf wants to merge 11 commits intospace-wizards:masterfrom
DrSmugleaf wants to merge 11 commits intospace-wizards:masterfrom
Conversation
DrSmugleaf
requested review from
ElectroJr and
PJB3005
and removed request for
PJB3005
Contributor
|
Hey that's pretty heckin cool |
PJB3005
requested changes
Jan 19, 2026
Member
PJB3005
left a comment
PJB3005
left a comment
There was a problem hiding this comment.
This needs to block private IP address ranges
Also no compile
Member
Author
|
@PJB3005 Fixed in |
PJB3005
requested changes
Jan 31, 2026
| if (IPAddress.TryParse(uri.Host, out var ip)) | ||
| ThrowIfLocalIP(ip); | ||
|
|
||
| var addresses = await Dns.GetHostAddressesAsync(uri.Host); |
Member
There was a problem hiding this comment.
I'd prefer if these were checked from the connection handler to avoid any TOCTOU shit.
Member
Author
There was a problem hiding this comment.
Done in 607dca3 (this PR) (assuming I did it properly)
Unrelated, not sure if the new JSON method is safe to expose to content sandbox-wise or not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge without PJB's approval I will blow up
My RMC GMs yearn for custom audio playing