Skip to content

Conversation

@NinaEilers
Copy link
Collaborator

Adding a picture to a already existing location.
It did not exist as automated feature.

👀 Seak Peek (Optional)

Include the link to the feature deployment or screenshots/a video.

💪 I have tested my code
  • [x ] A new E2e playwright test covers this feature / A new test that reproduces the bug passes now.
  • The feature deployment works.
  • [ x] The automated tests are passing.
  • I have manually tested this feature
    • on mobile
    • by using keyboard-only navigation
    • with a screen reader (VoiceOver is fine)
    • in Chrome
    • in Firefox
    • in Safari
🧼 I have cleaned up my code
  • [ x]I have removed dependencies that were just for testing.
  • [ x]I have removed debug logging.
🔍 I have performed a self-review of my code
✨ I have created a nice pull request
  • [ x] It has a clear title.
  • [ x] It follows the template, has a clear description and testing instructions if needed.
  • [ x] It references applicable Asana tickets.
  • [x ] It targets the right branch.
  • I removed not applicable sections of the PR template.
  • [optional] I added a GIF of my favorite animal to the PR description to lighten the mood of my colleagues.
📝 I updated the documentation
  • I updated the documentation in this repository.
  • I updated the tech manual.
  • I updated the manual testing plan of the app so that it includes a testing flow for this feature.

🔍 Reviewing

When reviewing this merge request, here are some things to keep in mind:

🍸 Optional: Installation instructions

Remove this section, if you don't need it
For example: Reinstall your dependencies, rebuild your docker image, add something to your .env

🔬 Optional: Testing instructions

Remove this section, if you don't need it
For example: To test this feature, click on the "Create" button, fill out the form, click "Save" and then upload a file.

@opyh opyh changed the title Description of adding a picture Add more tests Mar 4, 2025
and add some not-working to the tests working
delete test-1, test-5, test-11
@NinaEilers NinaEilers requested a review from opyh March 14, 2025 11:14
@opyh opyh self-assigned this May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants