-
Notifications
You must be signed in to change notification settings - Fork 15
Add more tests #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NinaEilers
wants to merge
23
commits into
feature/a11ymap
Choose a base branch
from
feature/a11ymap-tests
base: feature/a11ymap
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add more tests #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
functions during recording and does not function during playback
does not work afterwards
and add some not-working to the tests working
delete test-1, test-5, test-11
…lin-technical-university.spec.ts
0295cb6 to
3cbef2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a picture to a already existing location.
It did not exist as automated feature.
👀 Seak Peek (Optional)
Include the link to the feature deployment or screenshots/a video.
💪 I have tested my code
🧼 I have cleaned up my code
🔍 I have performed a self-review of my code
✨ I have created a nice pull request
📝 I updated the documentation
🔍 Reviewing
When reviewing this merge request, here are some things to keep in mind:
🍸 Optional: Installation instructions
Remove this section, if you don't need it
For example: Reinstall your dependencies, rebuild your docker image, add something to your
.env🔬 Optional: Testing instructions
Remove this section, if you don't need it
For example: To test this feature, click on the "Create" button, fill out the form, click "Save" and then upload a file.