Skip to content

Comments

Upgrade Sourcemeta dependencies#656

Merged
jviotti merged 1 commit intomainfrom
all-deps-bundle
Feb 23, 2026
Merged

Upgrade Sourcemeta dependencies#656
jviotti merged 1 commit intomainfrom
all-deps-bundle

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Feb 23, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

@augmentcode
Copy link

augmentcode bot commented Feb 23, 2026

🤖 Augment PR Summary

Summary: Updates vendored Sourcemeta dependency pins (core/blaze/jsonschema) to newer revisions and incorporates corresponding upstream vendor code changes.

Changes:

  • Bumped core, blaze, and jsonschema versions/revisions (including jsonschema 14.13.314.13.4) in dependency manifests.
  • Vendored core: refactored JSON Schema bundling to determine behavior from base_dialect(), added definitions_keyword(), and added logic to elevate embedded resources from remote schemas into the bundle container.
  • Vendored core alterschema: UnknownKeywordsPrefix now tracks renames and rebases references after keyword prefixing.
  • Vendored jsonschema: adjusted JSON input enumeration to sort results deterministically per entry/config and improved resolver error wrapping for additional schema exception types.
  • Fixed resolver duplicate-identifier detection to compare against the actual embedded subschema being registered.

Technical Notes: Bundling behavior for older drafts now hinges on the resolved base dialect and a computed embedded-schema container keyword, with standalone schemas short-circuiting before bundling.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

}

const sourcemeta::core::JSON::String identifier_string{identifier};
if (bundled.contains(identifier_string)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundled.contains(identifier_string) doesn’t necessarily mean an equivalent resource is already embedded under root_container (e.g., bundled also tracks “seen/mapped” identifiers and can map an identifier to a different effective id). In that case this branch will still erase the embedded $defs/definitions entry without any conflict check, which could silently drop a non-identical embedded resource.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.


const auto extensions{parse_extensions(options, std::nullopt)};
for (const auto &entry : arguments) {
const auto before{result.size()};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes ordering from a single global sort of result to per-argument segment sorts; if downstream relies on globally sorted traversal (independent of the user’s argument order), this could be a behavioral change. Worth confirming the new grouping-by-argument ordering is intentional for CLI determinism/UX.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@jviotti jviotti merged commit 20046a9 into main Feb 23, 2026
6 checks passed
@jviotti jviotti deleted the all-deps-bundle branch February 23, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant