Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: Updates vendored Sourcemeta dependency pins (core/blaze/jsonschema) to newer revisions and incorporates corresponding upstream vendor code changes. Changes:
Technical Notes: Bundling behavior for older drafts now hinges on the resolved base dialect and a computed embedded-schema container keyword, with standalone schemas short-circuiting before bundling. 🤖 Was this summary useful? React with 👍 or 👎 |
| } | ||
|
|
||
| const sourcemeta::core::JSON::String identifier_string{identifier}; | ||
| if (bundled.contains(identifier_string)) { |
There was a problem hiding this comment.
bundled.contains(identifier_string) doesn’t necessarily mean an equivalent resource is already embedded under root_container (e.g., bundled also tracks “seen/mapped” identifiers and can map an identifier to a different effective id). In that case this branch will still erase the embedded $defs/definitions entry without any conflict check, which could silently drop a non-identical embedded resource.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
|
|
||
| const auto extensions{parse_extensions(options, std::nullopt)}; | ||
| for (const auto &entry : arguments) { | ||
| const auto before{result.size()}; |
There was a problem hiding this comment.
This changes ordering from a single global sort of result to per-argument segment sorts; if downstream relies on globally sorted traversal (independent of the user’s argument order), this could be a behavioral change. Worth confirming the new grouping-by-argument ordering is intentional for CLI determinism/UX.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com