style(clang-tidy): Clean include headers of src/core/jsonpointer #1648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported by clang-tidy check misc-include-cleaner Refs: sourcemeta/blaze#429 Signed-off-by: Balakrishna Avulapati <[email protected]>
bavulapati
commented
May 18, 2025
jviotti
reviewed
May 18, 2025
jviotti
reviewed
May 18, 2025
src/core/jsonpointer/include/sourcemeta/core/jsonpointer_pointer.h
Outdated
Show resolved
Hide resolved
|
Looks good but please keep in mind header include ordering, using |
The order of the includes: sourcemeta includes followed by standard headers Also, sourcemeta headers use include paths Signed-off-by: Balakrishna Avulapati <[email protected]>
|
@jviotti addressed the comments. PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by clang-tidy check misc-include-cleaner
Refs: sourcemeta/blaze#429