-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Syntactic indexing: add database schema and dbworker #60055
Conversation
- repo-updater | ||
- gitserver-0 | ||
- gitserver-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we now require the repo table to be populated for the syntactic_scip_indexes_with_repository_name
view to work in joins, it's useful to have repo updater running locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some more comments; will do a third pass shortly over some of the SQL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blocking comments, but some questions and suggestions for improving readability.
The purpose of this test is to verify that the DB schema | ||
we're using for the syntactic code intel work matches | ||
the requirements of dbworker interface, | ||
and that we can dequeue records through this interface. | ||
|
||
The schema is sensitive to column names and types, and to the fact | ||
that we are using a Postgres view to query repository name alongside | ||
indexing records, | ||
so it's important that we use the real Postgres in this test to prevent | ||
schema/implementation drift. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this comment, it's very useful
@varungandhi-src once the build is green I will merge this - if you have any more comments, please add them here or raise a separate issue. |
Closes #59794
This PR:
dbworker
interfaceTest plan
New tests to ensure schema conformance.
For manual testing:
sg start codeintel-syntactic
insert into syntactic_scip_indexes(id, commit, repository_id, outfile) values (nextval('syntactic_scip_index_id_seq'), '8c0cc755be302107b675824b0fb1b985992092b8', 1, 'index.scip');