Skip to content

chore: Use faster 3 way string comparison #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
varungandhi-src merged 1 commit into from
Nov 30, 2024
Merged

chore: Use faster 3 way string comparison #292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions bindings/go/scip/sort.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package scip

import (
"sort"
"strings"

"golang.org/x/exp/slices"
)
Expand All @@ -24,12 +25,7 @@ func FindSymbol(document *Document, symbolName string) *SymbolInformation {
// and SymbolInformation values must be merged. This guarantee is upheld by CanonicalizeDocument.
func FindSymbolBinarySearch(canonicalizedDocument *Document, symbolName string) *SymbolInformation {
i, found := slices.BinarySearchFunc(canonicalizedDocument.Symbols, symbolName, func(sym *SymbolInformation, lookup string) int {
if sym.Symbol < lookup {
return -1
} else if sym.Symbol == lookup {
return 0
}
return 1
return strings.Compare(sym.Symbol, lookup)
})
if found {
return canonicalizedDocument.Symbols[i]
Expand Down