This repository was archived by the owner on Aug 1, 2025. It is now read-only.
Implement exclude patterns from workspace settings #8190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichim-david
suggested changes
Jul 23, 2025
| await this.fetchIfNeeded() | ||
|
|
||
| // Check VS Code exclude patterns | ||
| if (ContextFiltersProvider.excludePatternGetter) { |
Contributor
There was a problem hiding this comment.
@thenamankumar your pr description strikes-through the search exclusion but the code is still present as seen here
|
|
||
| if (useIgnoreFiles && workspaceFolder) { | ||
| sgignoreExclude = await readIgnoreFile( | ||
| vscode.Uri.joinPath(workspaceFolder.uri, '.cody', 'ignore') |
Contributor
There was a problem hiding this comment.
We should use .sourcegraph/ignore like we had in Beatrix's pr.
| return | ||
| } | ||
|
|
||
| const useIgnoreFiles = vscode.workspace |
Contributor
There was a problem hiding this comment.
Same it seems we rely on the vscode search exclusion which shouldn't happen based on the pr description
thenamankumar
force-pushed
the
naman/cody-ignore
branch
from
b9f23cf to
512108a
Compare
Contributor
|
There are genuine test failures where files cannot be mentioned as seen in this screenshot which needs to be fixed before this work can be merged |
thenamankumar
force-pushed
the
naman/cody-ignore
branch
2 times, most recently
from
3599ab9 to
960b53a
Compare
thenamankumar
force-pushed
the
naman/cody-ignore
branch
from
960b53a to
a950d31
Compare
ichim-david
approved these changes
Jul 31, 2025
Contributor
ichim-david
left a comment
ichim-david
left a comment
There was a problem hiding this comment.
Approving to unblock, the problem was always from the tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implementing PR: https://github.com/sourcegraph/cody/pull/8037
This introduces the ability to exclude files from Cody's context based on the
files.exclude, search.exclude, and .gitignore / .sourcegraph/.ignore.cody/ignorefiles located in the codebase root directory settings in VS Code.The
ContextFiltersProvidernow utilizes these settings to determine if a file should be ignored. This is achieved by:minimatchas a dependency to perform pattern matching.excludePatternGetterto fetch the exclude patterns and workspace folder.This enhancement ensures that Cody respects the user's VS Code settings for excluding files, preventing irrelevant files from being included in the context.
Note: .sourcegraph/.ignore instead of .codyignore so that the same file can be used across sourcegraph products and not just codyTest plan