Replace std::process::exit with ExitCode enum implementing Termination#600
Merged
sourcefrog merged 11 commits intomainfrom Feb 8, 2026
Merged
Replace std::process::exit with ExitCode enum implementing Termination#600sourcefrog merged 11 commits intomainfrom
sourcefrog merged 11 commits intomainfrom
Conversation
…exit Co-authored-by: sourcefrog <346355+sourcefrog@users.noreply.github.com>
Co-authored-by: sourcefrog <346355+sourcefrog@users.noreply.github.com>
Co-authored-by: sourcefrog <346355+sourcefrog@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove sys::exit for return code in main
Return ExitCode from main instead of calling std::process::exit
Feb 5, 2026
sourcefrog
requested changes
Feb 5, 2026
Co-authored-by: sourcefrog <346355+sourcefrog@users.noreply.github.com>
sourcefrog
reviewed
Feb 5, 2026
Co-authored-by: sourcefrog <346355+sourcefrog@users.noreply.github.com>
Copilot
AI
changed the title
Return ExitCode from main instead of calling std::process::exit
Return ExitCode enum from main instead of calling std::process::exit
Feb 8, 2026
sourcefrog
reviewed
Feb 8, 2026
sourcefrog
reviewed
Feb 8, 2026
sourcefrog
reviewed
Feb 8, 2026
Co-authored-by: sourcefrog <346355+sourcefrog@users.noreply.github.com>
…tcome.rs Co-authored-by: sourcefrog <346355+sourcefrog@users.noreply.github.com>
sourcefrog
reviewed
Feb 8, 2026
Co-authored-by: sourcefrog <346355+sourcefrog@users.noreply.github.com>
Co-authored-by: sourcefrog <346355+sourcefrog@users.noreply.github.com>
Copilot
AI
changed the title
Return ExitCode enum from main instead of calling std::process::exit
Replace std::process::exit with ExitCode enum and Termination trait
Feb 8, 2026
Co-authored-by: sourcefrog <346355+sourcefrog@users.noreply.github.com>
Copilot
AI
changed the title
Replace std::process::exit with ExitCode enum and Termination trait
Replace std::process::exit with ExitCode enum implementing Termination
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was calling
std::process::exit()directly, preventing proper resource cleanup and using non-idiomatic patterns for setting exit codes.Changes
Exit code enum with Termination trait
ExitCodeenum with#[repr(i32)]and explicit discriminants (0, 1, 2, 3, 4, 5, 6, 70)Terminationtrait allowing direct return from mainFrom<ExitCode>forstd::process::ExitCodeMain function signature
fn main() -> Result<()>tofn main() -> Result<ExitCode>std::process::exit()calls throughout codebase.into()conversions (handled by Termination trait)Return type updates
LabOutcome::exit_code()andDiffFilterError::exit_code()now returnExitCodeenumuse crate::exit_code::ExitCodeacross all filesBefore:
After:
Additional improvements
Usageexit code for invalid manifest pathscargo fmtOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.