Skip to content

Conversation

@pablomh
Copy link

@pablomh pablomh commented Aug 15, 2025

Allow the possibility to provide the sizelimit value using the log_size option.

Set it by default (when no option is provided) to the current value (500).


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Allow the possibility to provide the `sizelimit` value using the `log_size` option.

Set it by default (when no option is provided) to the current value (500).

Signed-off-by: Pablo Mendez Hernandez <[email protected]>
Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log_size is always set to some value, aside from when a user passes --all-logs, where we override it to None.

This would make it so that this collection is always following log_size, and also mean we only limit to 500mb when we are otherwise requesting we don't do any size limiting, which isn't desired.

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-4103
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants