Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted a proper dark mode which landed me at Boostrap 5 so here it is.
Have debated how much of the original looknfeel to keep and it would be 95% in the main screen with
But opted out of it for better font support and a bit more space.
Kept changes to minimum (no rem or css variables rewrite) to be easier to review, but it also means dark mode doesn't behave yet.
Major changes:
Dropdowns have changed in Bootstrap 4 so this includes a patch
boostrap-contextmenu
to fix them, and an upgrade to bassjobsen/Bootstrap-3-Typeahead@fc2d5dc which is Bootstrap 4 compatible.Was lazy to add
dropdown-item
to all entries so addedinitDropdownMenus()
to do so.Connection form probably got the greatest overhaul but tried to at least ensure the original layout.
Next changes
Enable dark-mode fix all misbehaving styles.LE: A dark mode prototype can be checked here:
agologan/pgweb@bootstrap-5...agologan:pgweb:dark-mode
Goal was again to maintain the light mode theme while enabling dark mode support.
Dark mode could be customized more and vars could be reduced by leaning more into the default theme structure.