Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the relevant notebook with a stand alone dataset download #895

Merged
merged 6 commits into from
Dec 28, 2023

Conversation

Idan-BenAmi
Copy link
Collaborator

@Idan-BenAmi Idan-BenAmi commented Dec 26, 2023

Pull Request Description:

Update the Keras PTQ notebook with a dataset download and make additional minor modifications.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

Copy link
Collaborator

@elad-c elad-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add comments for all files, same as in the effdet tutorial
  2. Consdier merging consecutive "markdown" cells to a single cell

tutorials/notebooks/example_keras_imagenet.ipynb Outdated Show resolved Hide resolved
tutorials/notebooks/example_keras_imagenet.ipynb Outdated Show resolved Hide resolved
tutorials/notebooks/example_keras_imagenet.ipynb Outdated Show resolved Hide resolved
tutorials/notebooks/example_keras_imagenet.ipynb Outdated Show resolved Hide resolved
tutorials/notebooks/example_keras_imagenet.ipynb Outdated Show resolved Hide resolved
@Idan-BenAmi Idan-BenAmi merged commit 6e07a86 into sony:main Dec 28, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants