Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Softmax layer in activation decomposition instead of Activation layer #894

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

reuvenperetz
Copy link
Collaborator

Pull Request Description:

In MP we need to know the axis used in Softmax for KL-Divergence computation. In activation decomposition, we created a simple 'Activation' layer thus we can not use the axis info when computing MP distance. This commit changes the decomposition to create a Softmax layer, thus enabling the KL-Divergence in MP distance computation.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

…n layer

In MP we need to know the axis used in Softmax for KL-Divergence computation.
In activation decomposition, we created a simple 'Activation' layer thus we can not
use the axis info when computing MP distance. This commit changes the decomposition
to create a Softmax layer, thus enabling the KL-Divergence in MP distance computation.
@reuvenperetz reuvenperetz requested a review from ofirgo December 26, 2023 10:33
@reuvenperetz reuvenperetz merged commit 4d4d3ac into sony:main Dec 26, 2023
23 of 24 checks passed
@reuvenperetz reuvenperetz deleted the fix-act-decomposition branch December 26, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants