Update the relevant notebook with a notation to use the latest MCT #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad-c
reviewed
Dec 20, 2023
| @@ -81,7 +80,8 @@ | |||
| { | |||
| "cell_type": "markdown", | |||
| "source": [ | |||
| "In order to convert the PyTorch model, you'll need to use the conversion code in the [MCT tutorials folder](https://github.com/sony/model_optimization/tree/main/tutorials), so we'll clone the MCT repository to a local folder and only use that code. The installed MCT package will be used for quantization. " | |||
| "In order to convert the PyTorch model, you'll need to use the conversion code in the [MCT tutorials folder](https://github.com/sony/model_optimization/tree/main/tutorials), so we'll clone the MCT repository to a local folder and only use that code. The installed MCT package will be used for quantization. \n", | |||
There was a problem hiding this comment.
not sure "latest version" is correct. maybe just say explicitly that you're running on the latest version of the source code
| @@ -107,6 +107,7 @@ | |||
| "source": [ | |||
| "import sys\n", | |||
| "sys.path.insert(0,\"/content/local_mct\")\n", | |||
| "!pip install -r /content/local_mct/requirements.txt\n", | |||
There was a problem hiding this comment.
maybe also run pip uninstall mctq and then get the latest code of mctq quantizers?
There was a problem hiding this comment.
we assume mctq version is updated in "requirements.txt"
elad-c
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Update the relevant notebook with a notation to use the latest MCT version.
Checklist before requesting a review: