Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move maxcut warning so it will only appear once. #1334

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Conversation

elad-c
Copy link
Collaborator

@elad-c elad-c commented Jan 20, 2025

Pull Request Description:

Move maxcut warning so it will only appear once.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@elad-c elad-c requested a review from ofirgo January 20, 2025 15:54
Copy link
Collaborator

@ofirgo ofirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to also add the condition to required_mixed_precision to always run MP when any other than weights is restricted

@elad-c elad-c merged commit e101f5c into main Jan 21, 2025
43 checks passed
@elad-c elad-c deleted the fix_maxcut_warning branch January 21, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants