Refactor Target Platform Capabilities - Phase 3 #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove context manager functionality from Target Platform Model. Fix all tests and tp models.
ofirgo
requested changes
Dec 18, 2024
| @@ -82,7 +82,10 @@ def is_opset_in_model(tp_model: TargetPlatformModel, opset_name: str) -> bool: | |||
| bool: True if an OperatorsSet with the given name exists in the target platform model, | |||
| otherwise False. | |||
| """ | |||
| return opset_name in [x.name for x in tp_model.operator_set] | |||
There was a problem hiding this comment.
return tp_model.operator_set is not None and opset_name in [x.name for x in tp_model.operator_set]
| @@ -52,7 +52,7 @@ def __init__(self, | |||
| self.op_sets_to_layers = OperationsToLayers() # Init an empty OperationsToLayers | |||
| self.layer2qco, self.filterlayer2qco = {}, {} # Init empty mappings from layers/LayerFilterParams to QC options | |||
| # Track the unused opsets for warning purposes. | |||
| self.__tp_model_opsets_not_used = [s.name for s in tp_model.operator_set] | |||
| self.__tp_model_opsets_not_used = [s.name for s in tp_model.operator_set] if tp_model.operator_set else [] | |||
There was a problem hiding this comment.
Can tp_model.operator_set be None? isn't it something that we want to raise exception on or is it a common case that we can handle?
anyway, I don;t like the empty list initialization here, if a None tp_model.operator_set might raise issues going forward than we should address it and not hide it with an empty list
…rboard when using this version of matplotlib (#1298)
Remove context manager functionality from Target Platform Model. Fix all tests and tp models.
ofirgo
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove context manager functionality from Target Platform Model. Fix all tests and tp models.
Make all schema classes fully immutable (no more lists).
Pull Request Description:
Checklist before requesting a review: