Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix package discovery for wheel #1257

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix package discovery for wheel #1257

merged 1 commit into from
Nov 6, 2024

Conversation

irenaby
Copy link
Collaborator

@irenaby irenaby commented Nov 4, 2024

Pull Request Description:

tests_pytest is included in the wheel as it was not explicitly excluded from find_packages.
Use include instead of exclude in find_packages to automatically exclude any new non-product code.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@irenaby irenaby requested a review from ofirgo November 4, 2024 14:11
Copy link
Collaborator

@ofirgo ofirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the docs? I don't know if this should be included as part of the package, but it wasn't excluded before.
I prefer to leave it with the exclude and just add the new package that we want to exclude

@irenaby
Copy link
Collaborator Author

irenaby commented Nov 5, 2024

@ofirgo docs are not included in the package. find_packages only looks for python packages, anything else need to be included explicitly with other arguments (i also don't see any reason why docs would be included in the wheel). Including only the product src code is much more robust, it was pure coincidence that I notice this at all.

@ofirgo
Copy link
Collaborator

ofirgo commented Nov 6, 2024

@ofirgo docs are not included in the package. find_packages only looks for python packages, anything else need to be included explicitly with other arguments (i also don't see any reason why docs would be included in the wheel). Including only the product src code is much more robust, it was pure coincidence that I notice this at all.

Ok, sounds reasonable

@irenaby irenaby merged commit ca780b3 into main Nov 6, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants