Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage workflow #1247

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Conversation

reuvenperetz
Copy link
Collaborator

Pull Request Description:

Use separate environments for coverage testing of Keras and Torch.
This fixes the issue of the flag "FOUND_TF" being set even if TF is uninstalled. The issue started with the start of pytest usage.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@reuvenperetz reuvenperetz requested a review from ofirgo October 15, 2024 13:28
Copy link
Collaborator

@ofirgo ofirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure - this produces a single coverage report, based on both test frameworks run?

@reuvenperetz reuvenperetz merged commit 5f52f1f into sony:main Oct 20, 2024
32 of 33 checks passed
@reuvenperetz reuvenperetz deleted the fix-coverage-workflow branch October 20, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants