Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip inline images in links checker test #1111

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

reuvenperetz
Copy link
Collaborator

Pull Request Description:

Ignore base64-encoded image links, as they are valid inline images and don't need to be checked as external or local links.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@reuvenperetz reuvenperetz merged commit 7770af9 into sony:main Jun 17, 2024
26 of 27 checks passed
@reuvenperetz reuvenperetz deleted the fix-links-checker branch June 17, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants