-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activation Hessian computation runtime optimization #1092
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuvenperetz
reviewed
Jun 4, 2024
model_compression_toolkit/core/common/hessian/hessian_info_service.py
Outdated
Show resolved
Hide resolved
model_compression_toolkit/core/common/hessian/hessian_info_service.py
Outdated
Show resolved
Hide resolved
model_compression_toolkit/core/keras/hessian/activation_trace_hessian_calculator_keras.py
Outdated
Show resolved
Hide resolved
reuvenperetz
approved these changes
Jun 5, 2024
reuvenperetz
reviewed
Jun 5, 2024
@@ -44,6 +45,7 @@ def __init__(self, | |||
norm_scores (bool): Whether to normalize the returned scores for the weighted distance metric (to get values between 0 and 1). | |||
refine_mp_solution (bool): Whether to try to improve the final mixed-precision configuration using a greedy algorithm that searches layers to increase their bit-width, or not. | |||
metric_normalization_threshold (float): A threshold for checking the mixed precision distance metric values, In case of values larger than this threshold, the metric will be scaled to prevent numerical issues. | |||
hessian_batch_size (int): The Hessian computation batch size. used only if using mixed precision with Hessian-based objective. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used, but not crucial.
reuvenperetz
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Improve Activation Hessian computation runtime for GPTQ and Mixed precision with the following optimizations:
Major design remarks:
Checklist before requesting a review: