Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TPC factory #1087

Merged
merged 3 commits into from
May 28, 2024
Merged

Refactor TPC factory #1087

merged 3 commits into from
May 28, 2024

Conversation

elad-c
Copy link
Collaborator

@elad-c elad-c commented May 27, 2024 •
edited
Loading

Pull Request Description:

Refactor TPC factory: only instantiate the requested TPC.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@elad-c elad-c requested a review from reuvenperetz May 27, 2024 11:55
@elad-c elad-c merged commit 7763d4c into main May 28, 2024
27 checks passed
@elad-c elad-c deleted the tpc_factory_refactor branch May 28, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reuvenperetz reuvenperetz reuvenperetz approved these changes

Assignees
No one assigned
Labels
auto:target_platform_capabilities auto:tests pr: refactoring/code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elad-c @reuvenperetz