Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactor to PyTorch model reader to handle tensors received in node's kwargs. #1073

Closed
wants to merge 2 commits into from
Closed

Small refactor to PyTorch model reader to handle tensors received in node's kwargs. #1073

wants to merge 2 commits into from

Conversation

elad-c
Copy link
Collaborator

@elad-c elad-c commented May 16, 2024 •
edited
Loading

Pull Request Description:

This PR fixes a bug that the "Const Representation" PR reveiled, that input tensors to a node through it's kwargs were not handled correctly.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@elad-c elad-c requested a review from ofirgo May 16, 2024 12:25
ofirgo
ofirgo requested changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@ofirgo ofirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly documentation comments, some testing comments

@elad-c elad-c closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofirgo ofirgo ofirgo requested changes

Assignees
No one assigned
Labels
auto:core auto:tests pr: bug fix pytorch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elad-c @ofirgo