Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the imx500 notebooks to install mct unless it's already installed #1068

Merged
merged 3 commits into from
May 12, 2024

Conversation

Idan-BenAmi
Copy link
Collaborator

@Idan-BenAmi Idan-BenAmi commented May 12, 2024

Pull Request Description:

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@@ -46,12 +46,11 @@
"outputs": [],
"source": [
"!pip install -q tensorflow\n",
"!pip install -q mct-nightly\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update colab link on this tutorial

@@ -103,7 +103,10 @@
"outputs": [],
"source": [
"!pip install -q tensorflow\n",
"!pip install -q mct-nightly"
"\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same. fix colab link

@@ -53,8 +53,7 @@
{
"cell_type": "markdown",
"source": [
"Clone a copy of the MCT (Model Compression Toolkit) into your current directory. This step ensures that you have access to [mct_model_garden](https://github.com/sony/model_optimization/tree/main/tutorials/mct_model_garden) folder which contains all the necessary utility functions for this tutorial\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same. fix colab link

@@ -53,8 +53,7 @@
{
"cell_type": "markdown",
"source": [
" Clone a copy of the [MCT](https://github.com/sony/model_optimization) (Model Compression Toolkit) into your current directory. This step ensures that you have access to [MCT Models Library](https://github.com/sony/model_optimization/tree/main/tutorials/mct_model_garden) folder which contains all the necessary utility functions for this tutorial.\n",
" **It's important to note that we use the most up-to-date MCT code available.**"
"Install MCT (if it’s not already installed). Additionally, in order to use all the necessary utility functions for this tutorial, we also copy this folder: MCT tutorials folder and add it to the system path."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"we also copy the MCT tutorials folder..." (remove "this folder:")

@@ -60,8 +60,7 @@
"collapsed": false
},
"source": [
" Clone a copy of the [MCT](https://github.com/sony/model_optimization) (Model Compression Toolkit) into your current directory. This step ensures that you have access to [MCT Models Garden](https://github.com/sony/model_optimization/tree/main/tutorials/mct_model_garden) folder which contains all the necessary utility functions for this tutorial.\n",
" **It's important to note that we use the most up-to-date MCT code available.**"
"Install MCT (if it’s not already installed). Additionally, in order to use all the necessary utility functions for this tutorial, we also copy this folder: MCT tutorials folder and add it to the system path."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@@ -61,8 +61,7 @@
"collapsed": false
},
"source": [
" Clone a copy of the [MCT](https://github.com/sony/model_optimization) (Model Compression Toolkit) into your current directory. This step ensures that you have access to [MCT Models Garden](https://github.com/sony/model_optimization/tree/main/tutorials/mct_model_garden) folder which contains all the necessary utility functions for this tutorial.\n",
" **It's important to note that we use the most up-to-date MCT code available.**"
"Install MCT (if it’s not already installed). Additionally, in order to use all the necessary utility functions for this tutorial, we also copy this folder: MCT tutorials folder and add it to the system path."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@Idan-BenAmi Idan-BenAmi merged commit f6805ab into sony:main May 12, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants