Display only external ports on single-asic systems by default #4140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align the behavior of multi-asic and single-asic to only display external ports by default.
This will fix certain sonic-mgmt tests on single-asic systems with internal ports that don't expect them to be there.
See sonic-net/sonic-mgmt#18249
Without this sonic-mgmt function calls like:
duthost.show_interface(command="status", include_internal_intfs=False)['ansible_facts']['int_status']Would return internal ports on single-asic systems despite being passed
include_internal_intfs=FalseWithout this change
qos/test_pfc_counters.pyfails on single-asic UT2 systems with:With this change the test passes.