Increase the installer disk size by 1GB and switch to ext2 for KVM #23378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following sonic-net#22199, the debug version of `sonic-vs.bin` file is at 4093MB (to be precise, one particular build was at 4291790831 bytes). This, in theory, should've fit fine in the 4096MB FAT32 installer disk that is created for building the sonic-vs.img QCOW2 image. However, it's short by 5MB. My guess for this reason is because FAT32 itself needs some space for metadata, and so we don't get the full 4096MB. This results in a failure to build the debug KVM image. As a fix, increase the installer disk size that we create by 8MB, which should be enough for any debug `sonic-vs.bin` file that we create for this filesystem. I say "for this filesystem" because FAT32 allows files up to 4GB (minus one byte). This means that if we need to create a debug image larger than this, then the installer disk will need to use a different filesystem, probably ext2 or ext4. Considering the ONIE recovery environment is a Linux environment, this will probably be perfectly fine if we do need to change to one of those two filesystems, as long as nothing has FAT32 hardcoded anywhere. Signed-off-by: Saikrishna Arcot <[email protected]>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
...and I just saw that the debug installer file in https://dev.azure.com/mssonic/build/_build/results?buildId=902172&view=results is at 4115MB. Looking at the diff between the prior build and this build, I don't see an obvious cause for the increase in size, but this might mean that the change to ext2/ext4 is needed now. |
Signed-off-by: Saikrishna Arcot <[email protected]>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Jul 18, 2025
Ryangwaite
approved these changes
Jul 18, 2025
saiarcot895
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Following #22199, the debug version of
sonic-vs.binfile is at 4093MB (to be precise, one particular build was at 4291790831 bytes). This, in theory, should've fit fine in the 4096MB FAT32 installer disk that is created for building the sonic-vs.img QCOW2 image. However, it's short by 5MB. My guess for this reason is because FAT32 itself needs some space for metadata, and so we don't get the full 4096MB. This results in a failure to build the debug KVM image.Work item tracking
How I did it
As a fix, increase the installer disk size that we create by 1GB, which should be enough for now, and switch to ext2 filesystem instead of FAT32. This switch is needed because FAT32 only allows files up to 4GB (minus one byte), and the latest debug images are at around 4.1GB.
How to verify it
I locally made a loopback file of 4104MB, copied the sonic-vs.bin debug installer file generated in https://dev.azure.com/mssonic/build/_build/results?buildId=900622&view=results into it (which is 4093MB), and verified that it did get copied into there.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)