feat(auth): human-readable server names and descriptions#380
Open
WilliamKarolDiCioccio wants to merge 1 commit into
Open
feat(auth): human-readable server names and descriptions#380WilliamKarolDiCioccio wants to merge 1 commit into
WilliamKarolDiCioccio wants to merge 1 commit into
Conversation
Fetch optional server identity from the new public GET /api/server endpoint during the connect probe, carry it through ConnectionSuccess, ServerEntry, and PreAuthState, and cache it with the persisted server so it shows on launch before any network call. Display the friendly name (with the raw address as a subtitle) across the connect/provider-selection flow, the server sidebar, the "Your Servers" list, and the versions header. The description appears on the pre-login provider-selection screen. Everything falls back to the raw address when the server provides no metadata (404 / unreachable), so the probe never fails on a missing or slow metadata call. Adds ServerInfo domain model + fetchServerInfo() in soliplex_client and discoverServerInfo() in soliplex_agent, with unit tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Shows a human-readable server name (e.g. "Demo Server") and a brief description in place of the raw server address (e.g.
demo.toughserv.com), sourced from the backend.Pairs with the backend PR adding
GET /api/server(soliplex/soliplex).How
ServerInfomodel +fetchServerInfo()insoliplex_client,discoverServerInfo()insoliplex_agent. Fetched during the connect probe alongside auth providers; a 404/timeout/network error never fails the probe (best-effort enrichment →null).ConnectionSuccess,ServerEntry(+displayNamegetter),ServerManager, andPreAuthState(so the web OAuth-redirect path keeps the name across page reload). Cached in secure storage, so the friendly name shows on launch before any network call.Testing
ServerInfo,fetchServerInfo(incl. 404 → null),discoverServerInfo, probeinfothreading, storage round-trip, andPreAuthStateround-trip.flutter analyzeclean.🤖 Generated with Claude Code