Update rspec-rails versions and fix tests #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adammathys
approved these changes
Sep 3, 2025
jarednorman
approved these changes
Sep 3, 2025
These versions were very old. Version 5.x is for Rails 5.2 and 6.x. 7.0 was removed from our CI tests so these are much older than we are testing. We added Rails 8 to the CI tests which means we should be using rspec-rails 8.x.
AlistairNorman
force-pushed
the
alistair/update-rspec-rails
branch
2 times, most recently
from
8e25a6f to
6faee34
Compare
If Rails isn't installed locally then this will fail.
This text is no longer outputted because we pass in the quiet flag and as of the commit linked below, we no longer use puts which previously ignored that flag. solidusio/solidus@0a0313a
AlistairNorman
changed the title
adammathys
approved these changes
Sep 5, 2025
jarednorman
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The versions we were requiring of rspec-rails did not match up with the current versions of Rails that are under test for this gem so I updated rspec-rails versions.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: