-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: update HTTP refs in protocol #561
Feat: update HTTP refs in protocol #561
Conversation
+1 to confining this PR to changes pertaining to updating some of the references. We can give citations and references for the whole document a pass in another PR, including improvements pertaining to style, guidelines, etc. |
Happy to give a short-ish response here but I suggest that we move the discussion on the topic elsewhere if anyone would like to follow-up. Somewhat semi-automated.
|
Co-authored-by: Sarven Capadisli <[email protected]>
Alright! I've been through this best I can. Contrary to the other reports I updated, there are some places here where there could be a minor impact on actual conformance to small changes in the details of RFC911x. I've tried to clearly indicate these in the table (rows with correction class 3), as well as give an assessment of the possible impact. This assesment is one of the following in all cases:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just left one nit-pick inline
Co-authored-by: Sarven Capadisli <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
In personal communication, @joachimvh indicated he sees no problem in the updates. |
Following up on #471, this PR updates the references to HTTP RFCs from the updated 3864 and obsolete 723x and 7540 to the replacing 911x.
Changes
HTML Preview | HTML Diff
If there still are any concerns about impact to conformance, you can check the relevant changelogs here:
On a sidenote: do you all manually update the HTML here? Bikeshed or ReSpec are quite handy in keeping track of references, amongst other things.