refactor: s3 버전 업그레이드 및 로직 수정 #608
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,51 +1,49 @@ | ||
| package com.example.solidconnection.s3.service; | ||
|
Member
There was a problem hiding this comment.
|
||
|
|
||
| import static com.example.solidconnection.common.exception.ErrorCode.S3_CLIENT_EXCEPTION; | ||
| import static com.example.solidconnection.common.exception.ErrorCode.S3_SERVICE_EXCEPTION; | ||
|
|
||
| import com.example.solidconnection.common.exception.CustomException; | ||
| import java.io.IOException; | ||
| import lombok.RequiredArgsConstructor; | ||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.springframework.scheduling.annotation.Async; | ||
| import org.springframework.stereotype.Component; | ||
| import org.springframework.web.multipart.MultipartFile; | ||
| import software.amazon.awssdk.core.exception.SdkException; | ||
| import software.amazon.awssdk.core.sync.RequestBody; | ||
| import software.amazon.awssdk.services.s3.S3Client; | ||
| import software.amazon.awssdk.services.s3.model.ObjectCannedACL; | ||
| import software.amazon.awssdk.services.s3.model.PutObjectRequest; | ||
| import software.amazon.awssdk.services.s3.model.S3Exception; | ||
|
|
||
| @Component | ||
| @Slf4j | ||
| @RequiredArgsConstructor | ||
| public class FileUploadService { | ||
|
|
||
| private final S3Client s3Client; | ||
|
|
||
| @Async | ||
| public void uploadFile(String bucket, String fileName, MultipartFile multipartFile) { | ||
|
Comment on lines
+27
to
+28
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# `@EnableAsync` 설정 확인
rg -n "@EnableAsync" --type javaRepository: solid-connection/solid-connect-server Length of output: 287 🏁 Script executed: #!/bin/bash
# 두 파일의 내용 확인 - `@EnableAsync` 주변 컨텍스트
echo "=== UpdateViewCountScheduler.java ==="
sed -n '1,30p' src/main/java/com/example/solidconnection/scheduler/UpdateViewCountScheduler.java
echo -e "\n=== UpdateViewCountService.java ==="
sed -n '1,30p' src/main/java/com/example/solidconnection/community/post/service/UpdateViewCountService.javaRepository: solid-connection/solid-connect-server Length of output: 2450
다음과 같은 사항을 확인했습니다:
🤖 Prompt for AI Agents
Contributor
Author
There was a problem hiding this comment. 이건 나중에 한 번에 바꿔야 할 것 같네 There was a problem hiding this comment.
필요하시다면 추적을 위한 GitHub 이슈를 생성해 드릴까요? 이슈에 현재 상황과 개선 방향을 정리해 두면 나중에 작업하실 때 도움이 될 것 같습니다. |
||
| try { | ||
| PutObjectRequest putObjectRequest = PutObjectRequest.builder() | ||
| .bucket(bucket) | ||
| .key(fileName) | ||
| .contentType(multipartFile.getContentType()) | ||
| .contentLength(multipartFile.getSize()) | ||
| .build(); | ||
|
|
||
| s3Client.putObject(putObjectRequest, | ||
| RequestBody.fromInputStream(multipartFile.getInputStream(), multipartFile.getSize())); | ||
|
|
||
| log.info("파일 업로드 정상 완료 thread: {}", Thread.currentThread().getName()); | ||
| } catch (S3Exception e) { | ||
| log.error("S3 서비스 예외 발생 : {}", e.awsErrorDetails().errorMessage()); | ||
| throw new CustomException(S3_SERVICE_EXCEPTION); | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } catch (SdkException | IOException e) { | ||
| log.error("S3 클라이언트 또는 IO 예외 발생 : {}", e.getMessage()); | ||
| throw new CustomException(S3_CLIENT_EXCEPTION); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이건 상수로 빼는 건 어떤가요 ?