Add image section to trial details page #5337
Conversation
…d displays images from each plot in a table
|
add accession name to table, make images a bit larger, allow sorting by columns |
|
I was not able to get this to run on cassava-devel. Tried two different trials and both hung on opening the trial images tab. Eventually got a javascript warning: For reference, the two trials I tried to view (and I do not know that they have images at all): trial ID 541 and trial ID 1228 |
|
@lukasmueller That sounds like a good idea, I will add that! |
| @@ -111,6 +111,24 @@ sub image_search :Path('/ajax/search/images') Args(0) { | |||
| my $image_page = "/image/view/$image_id"; | |||
| my $colorbox = qq|<a href="$image_img" title="<a href=$image_page>Go to image page ($image_name)</a>" class="image_search_group" rel="gallery-figures"><img src="$small_image" width="40" height="30" border="0" alt="$image_description" /></a>|; | |||
There was a problem hiding this comment.
in the img src tag, do not specify both width and height because that distorts images. I would just specify width, because that's important for the table, and the height is whatever it is
mason/image/plot_images.mas
Outdated
| @@ -12,6 +12,10 @@ $stockref => undef | |||
|
|
|||
| <& /util/import_javascript.mas, classes => [ 'jquery', 'thickbox', 'jquery.dataTables' ] &> | |||
|
|
|||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/jszip/3.7.1/jszip.min.js"></script> | |||
There was a problem hiding this comment.
This could also be done in the backend? If javascript, install it with npm?
| @@ -40,7 +40,7 @@ sub image_search :Path('/ajax/search/images') Args(0) { | |||
|
|
|||
| my @stock_name_list; | |||
| if (exists($params->{image_stock_uniquename}) && $params->{image_stock_uniquename}) { | |||
| push @stock_name_list, $params->{image_stock_uniquename}; | |||
| @stock_name_list = split /,/, $params->{image_stock_uniquename}; | |||
There was a problem hiding this comment.
Will this be compatible with previous usage? When a url parameter is repeated, it will appear as a listref here. So maybe check for it being a listref and handle that case, and then handle the case of the comma separated string?
|
|
||
| <script> | ||
|
|
||
| <%perl> |
There was a problem hiding this comment.
The authentication should not be needed, as the user is either unauthenticated and can't see this page, or they are already authenticataed and this shouldn't be necessary?
… stock name search
…e() in trial images test
|
Requires solgenomics/cxgn-corelibs#44 to be merged to pass tests |
|
add a note to meatadata that something was deleted? |
Description
Adds an image section to the trial details page that displays all of the images from every plot associated with the trial
Closes #5276
Checklist
/t/data/fixture/patches/./docshas been updated./jsto/js/source/legacy.