[js-legacy] Fix program check in amountToUiAmount helper functions

[gitteri]

Fix Program ID Validation in amountToUiAmount helpers

Problem

The amountToUiAmountForMintWithoutSimulation and uiAmountToAmountForMintWithoutSimulation functions currently has an incorrect program ID validation check that prevents valid mints from being processed. The current check:

if (programId !== TOKEN_PROGRAM_ID && programId !== TOKEN_2022_PROGRAM_ID)

uses an AND (&&) operator, which means the program ID must be BOTH the token program ID AND the token 2022 program ID. This is logically impossible since a program can only have one owner, effectively blocking all valid mints from being processed.

Solution

Change the AND (&&) operator to an OR (||) operator to properly validate that the program ID is either the token program ID OR the token 2022 program ID:

if (programId !== TOKEN_PROGRAM_ID || programId !== TOKEN_2022_PROGRAM_ID)

Impact

This fix will allow the function to properly process mints owned by either the SPL Token program or the Token-2022 program, which is the intended behavior. These functions will now correctly handle:

• Mints owned by the SPL Token program
• Mints owned by the Token-2022 program
• Properly reject mints owned by any other program

[joncinque]

Ah, right

[joncinque]

Wait, hold on, this means that token_2022 and token will throw

[joncinque]

The tests seem to agree that the code was fine before 😅