Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

ci: remove wasm-pack version lock #32307

Merged
merged 2 commits into from
Jun 28, 2023
Merged

ci: remove wasm-pack version lock #32307

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7011d9b
ci: remove wasm-pack version lock
yihau Jun 28, 2023
6085660
remove comment
yihau Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ci/docker-rust/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
# ci/rust-version.sh to pick up the new image tag
FROM rust:1.69.0

# we need to pin wasm-pack due to https://github.com/rustwasm/wasm-pack/issues/1308
RUN set -x \
&& apt update \
&& apt-get install apt-transport-https \
Expand Down Expand Up @@ -38,7 +37,7 @@ RUN set -x \
&& cargo install mdbook \
&& cargo install mdbook-linkcheck \
&& cargo install svgbob_cli \
&& cargo install --version 0.11.1 wasm-pack \
&& cargo install wasm-pack \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about removing comment at line 5?, which was added at #32239

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for pointing this out! 6085660

&& cargo install sccache \
&& rustc --version \
&& cargo --version