Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Remove redundant clones #31685

Merged
merged 5 commits into from
May 23, 2023
Merged

Conversation

apfitzge
Copy link
Contributor

Problem

cargo nightly started flagging on some redundant clones. Some are false positives, others are not.

Summary of Changes

Fix the actual redundant clones.

Fixes #

@apfitzge
Copy link
Contributor Author

False positives showing up after: #31381

@apfitzge apfitzge requested a review from brooksprumo May 16, 2023 22:29
@apfitzge apfitzge marked this pull request as ready for review May 16, 2023 23:57
@apfitzge apfitzge requested a review from ryoqun May 18, 2023 21:23
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ryoqun ryoqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(delayed) lgtm after brooksprumo

wen happy happy cleaning pr merge time? lol

@apfitzge apfitzge merged commit 5448d0b into solana-labs:master May 23, 2023
@apfitzge apfitzge deleted the nightly/redundant_clones branch May 23, 2023 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants