-
Notifications
You must be signed in to change notification settings - Fork 496
feat: Add components and utilities for interactive IDL #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Add components and utilities for interactive IDL #769
Conversation
|
@askov is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
Generated with ❤️ by ellipsis.dev |
| ); | ||
|
|
||
| // Original IDL atom | ||
| const orignalIdl = atom<BaseIdl | undefined>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
| const orignalIdl = atom<BaseIdl | undefined>(); | |
| const originalIdl = atom<BaseIdl | undefined>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks
|
|
||
| export function InteractInstruction({ | ||
| instruction, | ||
| onExecuteInstruciton, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
| onExecuteInstruciton, | |
| onExecuteInstruction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
| export const originalIdlAtom = atom( | ||
| get => { | ||
| const v = get(orignalIdl); | ||
| // if (v === undefined) throw new Error('orignalIdl is absent'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
a60bcaf to
9751abe
Compare
Description
Added components and utilities for interactive IDL feature.
This PR depends on #768, so there is actually only one commit. Should be rebased as soon as the base PR is merged
Reviewing the stories is optional. This code does not affect production and is intended for developers only.
Type of change
Type of change
Screenshots
Wallet component example
Testing
Related Issues
N/A
Checklist