Skip to content

Conversation

@overbit
Copy link
Contributor

@overbit overbit commented Aug 1, 2025

Description

This pull request introduces a new "Files" tab for Metaplex NFTs, adding functionality to display associated files and enhancing the user interface with new components and tests. The most important changes include creating new components for rendering Metaplex NFT files, updating the tab configuration to include the "Files" tab, and adding comprehensive tests to ensure functionality.

New Components and Functionality:

Tab Configuration Updates:

Tests:

Type of change

  • Bug fix
  • New feature
  • Protocol integration
  • Documentation update
  • Other (please describe):

Screenshots

BEFORE
image

AFTER
image

Testing

Manual testing was also performed on devnet, using the following token:

http://localhost:3000/address/9a1nsHmVZsAHhyoHbAvK2CbShg6FsNTkohPfTKz8MCwt/files?cluster=devnet

Related Issues

Fixes #665

Checklist

  • My code follows the project's style guidelines
  • I have added tests that prove my fix/feature works
  • All tests pass locally and in CI
  • I have updated documentation as needed
  • CI/CD checks pass
  • I have included screenshots for protocol screens (if applicable)
  • For security-related features, I have included links to related information

Additional Notes

@vercel
Copy link

vercel bot commented Aug 1, 2025

@overbit is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@overbit overbit force-pushed the add-metaplex-files branch from d6fdf94 to eac9889 Compare August 1, 2025 15:20
@overbit overbit marked this pull request as ready for review August 1, 2025 15:22
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to eac9889 in 2 minutes and 6 seconds. Click for details.
  • Reviewed 748 lines of code in 7 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. app/address/[address]/layout.tsx:111
  • Draft comment:
    The tab key was changed from 'metaplexNFT' to 'metaplex'. Ensure that all downstream routing and related logic are updated accordingly.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to ensure that all downstream routing and related logic are updated accordingly. This falls under asking the author to ensure something is tested or verified, which is against the rules. The comment does not provide a specific suggestion or point out a specific issue, so it should be removed.
2. app/address/[address]/layout.tsx:58
  • Draft comment:
    The PR description mentions resolving an issue regarding transaction history for deleted accounts, but the changes here only add a new Files tab for Metaplex NFTs. Please verify that the intended issue is fully addressed.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. app/components/account/__tests__/MetaplexFilesCard.test.tsx:31
  • Draft comment:
    Global fetch is mocked here. Ensure that this global override does not leak into other tests or consider restoring global.fetch after these tests if necessary.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% 1. The comment is about test infrastructure rather than actual code changes. 2. The test file already follows best practices by using beforeEach() to reset mocks. 3. Global mocks in test files are a common and accepted practice. 4. The comment is speculative about potential issues rather than pointing out an actual problem. The comment raises a valid concern about test isolation, which is important for maintaining a reliable test suite. However, the test file already handles this correctly through vi.clearAllMocks() and proper test isolation. The comment is overly cautious about a non-issue. Delete the comment as it raises speculative concerns about a properly implemented testing pattern.

Workflow ID: wflow_CiOVObTOvatyMUND

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@overbit
Copy link
Contributor Author

overbit commented Aug 4, 2025

@ngundotra can I get a review on this?

@ngundotra
Copy link
Contributor

Why not show the whole metadata json in the tab, instead of just doing showing Files ?

@overbit
Copy link
Contributor Author

overbit commented Aug 7, 2025

@ngundotra we could do that as an another page. This files allows consistency with the attributes page

@overbit
Copy link
Contributor Author

overbit commented Aug 13, 2025

@ngundotra WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Visualise Files for tokens created with Metaplex

3 participants