Sigverify Ed25519 Payload Decoding Standard #459
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LukasDeco
reviewed
Feb 10, 2025
| const data = decodedMessage.data; | ||
|
|
||
| if (!name || !data) { | ||
| return null; |
There was a problem hiding this comment.
Should you instead just fallback to rendering the message as a base64 string like in the clause above?
Contributor
Author
There was a problem hiding this comment.
yea you were right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD - sRFC number (waiting on Drift)
This PR adds support for decoding Ed25519 payloads that reference another program's instructions.
Example transaction on devnet - for local testing
Future to-do: