Feature/276 harvesting metadata from a provided repository url #278
Conversation
|
@sferenz |
|
Harvesting metadata from the provided URL (GitHub/GitLab). Command: |
|
@sferenz |
| @@ -131,7 +131,7 @@ def init_command_parser(self, command_parser: argparse.ArgumentParser) -> None: | |||
| def load_settings(self, args: argparse.Namespace): | |||
| """Load settings from the configuration file (passed in from command line).""" | |||
|
|
|||
| toml_data = toml.load(args.path / args.config) | |||
| toml_data = toml.load("." / args.config) | |||
There was a problem hiding this comment.
Does this still work if a regular path is given to HERMES?
There was a problem hiding this comment.
Yes, specifying a directory path containing CFF or CodeMeta files is also acceptable. For example, the following command works:
hermes harvest --path C:\path\to\your\directory
| @@ -25,7 +25,7 @@ def __call__(self, command: HermesCommand) -> t.Tuple[t.Dict, t.Dict]: | |||
| pass | |||
|
|
|||
|
|
|||
| class HarvestSettings(BaseModel): | |||
| class _HarvestSettings(BaseModel): | |||
There was a problem hiding this comment.
I didn’t intend to change the class name. There was an issue with incorrectly pulling the original code for base.py from an updated version of it. This occurred due to a recent update in the settings classes, where all were made private in the develop branch of HERMES (commit a6c1a5e).
| return None | ||
|
|
||
|
|
||
| def _download_to_tempfile(url: str, filename: str) -> pathlib.Path: |
There was a problem hiding this comment.
Do you delete the tempfiles later?
There was a problem hiding this comment.
In the current code the temp files for CFF and CodeMeta are stored separately in C:\Temp on the local machine.
There was a problem hiding this comment.
Will these files be deleted after the extraction process?
There was a problem hiding this comment.
The files won't be deleted after harvesting, however, I can modify the code to delete temp files after extraction. Do you agree with this change?
There was a problem hiding this comment.
Yes, I think the temp files should be deleted at the end of the process.
@sferenz Thank you for the comments. |
Add functionality to remove temp files generated during remote harvesting.
Remove temp files after harvesting CFF metadata
Added the URL to the
hermes harvestcommand. Now, the commandhermes harvestharvest the metadata from the local repository, andhermes harvest --url <URL>allows harvesting metadata from the provided URL, with support for GitHub and GitLab repositories.(e.g.,
hermes harvest --url https://github.com/NFDI4Energy/SMECS)