feat: anchor patch validation errors#3050
Draft
Arcticae wants to merge 1 commit intospr/main/44c79848from
Draft
Conversation
Arcticae
requested review from
maciektr and
wawel37
and removed request for
a team
This was referenced Mar 18, 2026
Arcticae
force-pushed
the
spr/main/bfdde9c1
branch
3 times, most recently
from
f76b386 to
e3b1f1b
Compare
Arcticae
force-pushed
the
spr/main/44c79848
branch
from
5d05c5e to
c8a1572
Compare
Arcticae
force-pushed
the
spr/main/bfdde9c1
branch
2 times, most recently
from
3e02108 to
18ccc5c
Compare
Arcticae
force-pushed
the
spr/main/44c79848
branch
from
c8a1572 to
5e639c2
Compare
Convert patch section validation errors (PatchNotInWorkspaceRoot, PatchSourceConflict, PatchSourceInvalidUrl) to ManifestSemanticError variants with span anchors. Thread ManifestDiagnosticAnchor through patch dependency parsing so errors in patch deps also carry locations. commit-id:bfdde9c1
Arcticae
force-pushed
the
spr/main/bfdde9c1
branch
from
18ccc5c to
fcd7d1f
Compare
Arcticae
force-pushed
the
spr/main/44c79848
branch
from
5e639c2 to
dddf7e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert patch section validation errors (PatchNotInWorkspaceRoot,
PatchSourceConflict, PatchSourceInvalidUrl) to ManifestSemanticError
variants with span anchors. Thread ManifestDiagnosticAnchor through
patch dependency parsing so errors in patch deps also carry locations.
Stack: