fix: Handle exceptions from child views during drawing operations#3593
Open
erhard-pspdfkit wants to merge 1 commit intosoftware-mansion:mainfrom
Open
fix: Handle exceptions from child views during drawing operations#3593erhard-pspdfkit wants to merge 1 commit intosoftware-mansion:mainfrom
erhard-pspdfkit wants to merge 1 commit intosoftware-mansion:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During navigation transitions,
ScreenStack.performDraw()can attempt to draw child views that are being recycled or destroyed. If anIllegalStateExceptionorRuntimeExceptionis thrown by a UI library when their views are drawn while in an invalid state, the app crashes.The Android drawing system queues drawing operations during navigation transitions. When views are recycled before these operations execute, child views may throw exceptions that propagate up to
react-native-screens'sScreenStack.performDraw(), crashing the app.Add exception handling in
performDraw()to gracefully handle exceptions from child views during drawing operations. This is a defensive practice that improves robustness without affecting normal operation.Changes
super.drawChild()in try-catch to handleIllegalStateExceptionandRuntimeExceptionChecklist