Conversation
iwoplaza
requested review from
aleksanderkatan,
cieplypolar,
Copilot and
reczkok
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (350 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
There was a problem hiding this comment.
Pull request overview
Adjusts AccessorBase’s internal slot creation to remain unnamed even when downstream bundling/code transforms rewrite imports, preventing unplugin-typegpu auto-naming from triggering in certain setups.
Changes:
- Replace aliased import (
slot as slotConstructor) with a directslotimport. - Wrap internal
slot(defaultValue)creation in an IIFE to avoid auto-naming triggers during transforms.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolution Time Benchmark---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.82, 1.55, 3.48, 5.38, 6.15, 8.87, 17.50, 21.22]
line [0.86, 1.65, 3.56, 5.98, 6.23, 9.37, 19.27, 18.57]
line [0.79, 1.65, 3.64, 4.97, 6.34, 8.48, 17.71, 20.63]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.32, 0.52, 0.62, 0.77, 1.03, 1.06, 1.27, 1.38]
line [0.32, 0.54, 0.66, 0.78, 1.05, 1.11, 1.26, 1.41]
line [0.27, 0.47, 0.61, 0.79, 0.99, 1.08, 1.25, 1.39]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.76, 1.83, 2.98, 5.15, 10.13, 22.07, 48.95, 95.09]
line [0.77, 1.85, 3.32, 5.30, 10.67, 23.46, 49.33, 96.73]
line [0.72, 1.74, 3.56, 5.15, 10.09, 21.32, 48.63, 96.32]
|
iwoplaza
force-pushed
the
fix/change-the-way-accessor-internal-slot-is-unnamed
branch
from
d31abd2 to
aaf8d6f
Compare
reczkok
approved these changes
May 5, 2026
cieplypolar
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the package bundling process caused the import rename to be reverted back to
slot, so we wrap it in an IIFE instead, which achieves the same effect