WIP: Ensure open handles lists correctly#316
Draft
jakirkham wants to merge 2 commits intosoft-matter:mainfrom
Draft
WIP: Ensure open handles lists correctly#316jakirkham wants to merge 2 commits intosoft-matter:mainfrom
open handles lists correctly#316jakirkham wants to merge 2 commits intosoft-matter:mainfrom
Conversation
jakirkham
force-pushed
the
fix_open_list
branch
from
7efb5e6 to
6216de1
Compare
The call to `glob` was causing `list`s of files to fail in `open`. This fixes that issue by looping over the `list`s contents, calling `glob` on each one, and concatenating them into a list of files.
jakirkham
force-pushed
the
fix_open_list
branch
from
6216de1 to
474a9ff
Compare
jakirkham
force-pushed
the
fix_open_list
branch
from
a3a14a5 to
7141a75
Compare
jakirkham
changed the title
open handles lists correctlyopen handles lists correctly
Contributor
|
@jakirkham is this PR still up to date? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #310
The call to
globwas causinglists of files to fail inopen. This fixes that issue by looping over thelists contents and concatenating them.