Tweaks for Sofatutor #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # lib/pull_preview/up.rb
This reverts commit 2fe79a2.
…e having a clear white list policy here.
mfittko
reviewed
Feb 24, 2023
| ].join(" && "), | ||
| instance_snapshot_name: latest_snapshot.name, | ||
| })) | ||
| client.create_instances_from_snapshot(params.merge( |
There was a problem hiding this comment.
pull provisioner refactoring to separate PR
mfittko
reviewed
Feb 24, 2023
| def latest_snapshot | ||
| @latest_snapshot ||= client.get_instance_snapshots.instance_snapshots.sort{|a,b| b.created_at <=> a.created_at}.find do |snap| | ||
| snap.state == "available" && snap.from_instance_name == name | ||
| snap.state == "available" && (snap.name == snapshot_name || snap.from_instance_name == name) |
mfittko
reviewed
Feb 24, 2023
lib/pull_preview/instance.rb
Outdated
| dns | ||
| ].join(".") | ||
| end | ||
|
|
||
| def url | ||
| scheme = (default_port == "443" ? "https" : "http") | ||
| "#{scheme}://#{public_dns}:#{default_port}" | ||
| "#{scheme}://#{basic_auth && basic_auth + '@'}#{public_dns}:#{default_port}/" |
mfittko
reviewed
Feb 24, 2023
lib/pull_preview/up.rb
Outdated
| @@ -21,7 +21,7 @@ def self.run(app_path, opts) | |||
| instance_name = opts[:name] | |||
|
|
|||
| PullPreview.logger.info "Taring up repository at #{app_path.inspect}..." | |||
| unless system("tar czf /tmp/app.tar.gz --exclude .git -C '#{app_path}' .") | |||
| unless system("tar czf /tmp/app.tar.gz --exclude=.git --exclude-from=.dockerignore -C '#{app_path}' .") | |||
There was a problem hiding this comment.
only add --exclude-from=.dockerignore if .dockerignore file exists!
mfittko
reviewed
Feb 24, 2023
| @@ -50,7 +50,7 @@ def self.run(app_path, opts) | |||
| end | |||
| end.bundle_id | |||
|
|
|||
| instance.launch(azs.first, bundle_id, blueprint_id, tags) | |||
| instance.launch(azs.sample, bundle_id, blueprint_id, tags) | |||
There was a problem hiding this comment.
pull out as it is selecting the availability zone randomly
… to 0.0.3 This commit updates the terminal-table gem to version 3.0.2, adjusts the unicode-display_width dependency to be compatible, and updates the pullpreview gem version to 0.0.3. Additionally, it updates the Bundler version to 2.4.22 and makes minor adjustments to other dependencies for compatibility.
This commit updates aws-sdk-lightsail to 1.32.0, octokit to 4.22.0, and slop to 4.10.1, ensuring compatibility and leveraging the latest features and bug fixes from these libraries. Terminal-table dependency version is relaxed to "~> 3.0".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2.