Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v6.40 #337

Merged
merged 10 commits into from
Dec 1, 2023
Merged

Release/v6.40 #337

merged 10 commits into from
Dec 1, 2023

Conversation

huanglongchao
Copy link
Contributor

@huanglongchao huanglongchao commented Oct 1, 2023

Motivation:

  1. fix app revision not exist
  2. Solve the problem that the session starts slowly after the multi-Idc feature is turned on
  3. Reduce the impact of session operation and maintenance on app traffic off
  4. fix Issue of high CPU usage by the meta leader

Result:

#335
#336
#339
#340

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #337 (fd6589e) into master (79ffc04) will increase coverage by 0.04%.
The diff coverage is 80.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #337      +/-   ##
============================================
+ Coverage     76.56%   76.61%   +0.04%     
  Complexity       48       48              
============================================
  Files           495      495              
  Lines         18488    18506      +18     
  Branches       1802     1805       +3     
============================================
+ Hits          14155    14178      +23     
+ Misses         3522     3515       -7     
- Partials        811      813       +2     
Files Coverage Δ
...egistry/common/model/constants/ValueConstants.java 93.61% <100.00%> (+0.28%) ⬆️
...ipay/sofa/registry/jdbc/informer/BaseInformer.java 93.63% <100.00%> (+0.17%) ⬆️
...c/repository/impl/InterfaceAppsJdbcRepository.java 83.67% <ø> (ø)
...server/meta/provide/data/NodeOperatingService.java 77.77% <85.71%> (+0.85%) ⬆️
...server/session/metadata/MetadataCacheRegistry.java 78.78% <80.00%> (+0.66%) ⬆️
...dbc/repository/impl/AppRevisionJdbcRepository.java 69.91% <75.00%> (+5.98%) ⬆️
.../java/com/alipay/sofa/registry/util/JsonUtils.java 72.22% <50.00%> (-6.35%) ⬇️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ffc04...fd6589e. Read the comment docs.

@sofastack-cla sofastack-cla bot added size/L and removed size/M labels Nov 21, 2023
Adjust the revision exception
this.provideDataService = provideDataService;
}
if (null != currentVersion) {
if (response.getEntity().getVersion() <= currentVersion.o1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this currentVersion may not be concurrency safe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why worry about concurrency when there is no multi-value write operation?

Copy link
Member

@nocvalight nocvalight Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method queryOperateInfoAndVersion() is a public method, we cannot assume that the queryOperateInfoAndVersion() method will always be called by a single thread. If queryOperateInfoAndVersion() was called concurrency, the currentVersion will write concurrency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All updates currentVer from db, Concurrent writes are also not a problem, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And db config is updated by Optimistic Locking with version

@huanglongchao huanglongchao merged commit 3d8297a into sofastack:master Dec 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants