-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v6.40 #337
Release/v6.40 #337
Conversation
…, otherwise session start is very slowly
...re/jdbc/src/main/java/com/alipay/sofa/registry/jdbc/exception/RevisionNotExistException.java
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
============================================
+ Coverage 76.56% 76.61% +0.04%
Complexity 48 48
============================================
Files 495 495
Lines 18488 18506 +18
Branches 1802 1805 +3
============================================
+ Hits 14155 14178 +23
+ Misses 3522 3515 -7
- Partials 811 813 +2
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Adjust the revision exception
473b4e3
to
3f8d150
Compare
.../meta/src/main/java/com/alipay/sofa/registry/server/meta/resource/filter/AuthRestFilter.java
Outdated
Show resolved
Hide resolved
.../meta/src/main/java/com/alipay/sofa/registry/server/meta/resource/filter/AuthRestFilter.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/alipay/sofa/registry/common/model/metaserver/NodeServerOperateInfoTest.java
Outdated
Show resolved
Hide resolved
db7549d
to
59d8d69
Compare
...rc/test/java/com/alipay/sofa/registry/common/model/metaserver/NodeServerOperateInfoTest.java
Show resolved
Hide resolved
59d8d69
to
c574865
Compare
this.provideDataService = provideDataService; | ||
} | ||
if (null != currentVersion) { | ||
if (response.getEntity().getVersion() <= currentVersion.o1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this currentVersion may not be concurrency safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why worry about concurrency when there is no multi-value write operation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method queryOperateInfoAndVersion() is a public method, we cannot assume that the queryOperateInfoAndVersion() method will always be called by a single thread. If queryOperateInfoAndVersion() was called concurrency, the currentVersion will write concurrency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All updates currentVer from db, Concurrent writes are also not a problem, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And db config is updated by Optimistic Locking with version
43e941e
to
6976faa
Compare
55319a1
to
fd6589e
Compare
Motivation:
Result:
#335
#336
#339
#340