Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize performance : Hessian2Input.readObject() for 'B' or 'b' #120

Open
wants to merge 3 commits into
base: 3.x
Choose a base branch
from

Conversation

chjk
Copy link

@chjk chjk commented Dec 20, 2024

这是一个对Hessian读取大byte[]的性能优化。读取耗时较优化前降低80%以上。

【优化原理】
原始读取逻辑:每次从流中读取256字节,然后处理后,放入一个新的ByteArrayOutputStream,如此循环后,最后再用ByteArrayOutputStream生成一个大的byte[]
本次优化:
1、对于只有一个chunk(总字节长度小于等于32768)的字节数组,不需要额外生成ByteArrayOutputStream了,而是直接读取chunk头上的字节长度,一次性生成固定长度的byte[]。然后将buffer中已经读取的一部分先写入到byte[]中,最后计算剩余应该从is流中读取的字节长度,使用_is.read(目标数组, 目标数组偏移量, 读取长度)的方法,一次性读取。
2、对于有多个chunk的字节数组,每个chunk使用上述步骤一次性读取,然后放入到ByteArrayOutputStream,多个chunk读取完成后,通过ByteArrayOutputStream输出拼接的byte[]

数据正确性测试:Hessian2InputTest.testSerialize()
简单的性能测试:Hessian2InputTest.testSerializeTime()

MacBook M1,测试结果如下:

单chunk的情况:反序列化byte[1024], 10000次:
优化前:56ms
优化后:36ms

单chunk的情况:反序列化byte[10*1024], 10000次:
优化前:312ms
优化后:40ms

单chunk的情况:反序列化byte[32000], 10000次:
优化前:824ms (随字节长度线性增长)
优化后:54ms (几乎无增长)

多chunk的情况:反序列化byte[1024*1024], 10000次:
优化前:24609ms
优化后:2225ms (降低90%)

Copy link

coderabbitai bot commented Dec 20, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Lo1nt Lo1nt requested review from OrezzerO, EvenLjj and Lo1nt December 20, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant